-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluesky Social (Independent Publisher) #3706
base: dev
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree company="Dan Romano aka IDR, Inc. dba SWOLCAT" |
Hi Dan, I have a connector I’m working on too. Are you building more out or is this what you are going to submit (without the Proposal)? |
Hi Troy, I will be building out more. These three actions are just the start and will be expanding in the next few hours. To get this up and running, we only need three actions but there's a lot more than we can and will add, naturally. What do you think? |
I tend to build them all. Are you having any problems with the OAuth? |
Right now, I've got basic auth going with the app passwords and rooting around for OAuth...but not seeing where we can create a client and secret. Posted in the dev channel on Bluesky but no response yet (recent post). |
@krautrocker Dan, please remove changes to the BkkFutar connector, I am not yet planning to update its authentication ;) |
Damn, my mistake - will remove at once this evening. |
This reverts commit ea3bcd3.
- Updated readme file
- Removed endpoints temporarily, adding back tomorrow
- Modified endpoints in readme
- .gitignore removal
Delete .gitignore
@vmanoharas Alrighty, I removed the .gitignore file and I'm in the process of consolidating the folders for ease of review and clarity. Thanks for the help, will have this finished ASAP for review next week. |
- Added request responses - Updated definitions for references within endpoints - Validated with paconn, no errors
…cker/PowerPlatformConnectors into bluesky-social-connector
- Validated with paconn, no errors - Moved global definitions position Ready to test with a client and secret.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to test, but a few housekeeping items do remain. This PR is indeed different from this other PR #3711 but may merge the branches.
- Added connection parameters to apiProperties - Added policy templates to apiProperties - Added endpoint for refreshSession - Validated with paconn, no errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this PR, I implemented connection parameters and policy templates per @Laskewitz guidance. I tested this in a flow and it works.
Additional testing required for authentication and, naturally, the other 70+ endpoints. actor, for example, is a parameter in about 12 endpoints that needed to be changed from actorId to just actor. QA + testing ready.
Hello @krautrocker, Can you please remove the word Proposal from the title? |
…OpenAPI spec (though not 3.0) - Removed dead code for definitions if they were only referenced but never uses. - Combined all endpoints into a single connector. Not yet comprehensive but on the way to a one-stop shop. - Validated with paconn, no errors.
1.) Endpoints QA'd Though not yet complete, I took a different approach today to effectively align the endpoints with Bluesky's specs. Parameters are matching up in both name and composition. 2.) All-in-one I am combining all namespaces and endpoints into a single connector. So far, so good. If this goes well, then there will be only one PR. 3.) Connector size Small, only 150KB so far. The definition references really do save space, and there's probably more room for enhancement here. Global definitions have been a great start, which has cut down on code bulk. 4.) Removed dead code A few definitions were "declared but never used." These have been removed. /**/ Plan for tomorrow:
Plan after tomorrow:
|
- Added 401 to responses. - Validated with paconn, no errors.
Only 50 endpoints remaining. Validation is clean. The rest will be completed tomorrow. File size is far below the 1MB limit. In order to test this, I will need play around in Bluesky. Create lists, get a post Id or other item and conduct operations on it via endpoints. |
- Removed dead code, ProfileViewBasic. - Added definition for 401 errors. - Validated with paconn, no errors.
… getBlob, and uploadBlob. - Validated with paconn, no errors. - Custom connector editor UI returns no errors or warnings.
Notes:
Housekeeping items to be completed tomorrow. /**/ This is ready to test. The app.bsky endpoints will be straight-forward. The "control panel" endpoints may require some thought but none of them seem supernatural. |
In the process of creating test cases for all endpoints. This will include happy paths and expected output for response codes. 🖖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @krautrocker,
Kindly address the review comments and please go through the below document and update all the artifacts related to independent publisher.
"app.bsky.actor" | ||
], | ||
"summary": "Get Preferences for Current Account", | ||
"description": "*This endpoint is part of the Bluesky application Lexicon APIs (app.bsky.*). Public endpoints which don't require authentication can be made directly against the public Bluesky AppView API: https://public.api.bsky.app. Authenticated requests are usually made to the user's PDS, with automatic service proxying. Authenticated requests can be used for both public and non-public endpoints.* *To learn more about calling atproto API endpoints like this one, see the Get private preferences attached to the current account. Expected use is synchronization between multiple devices and import/export during account migration. Requires authentication.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep all parameters descriptions short to fit in the text box. please see our docs.
@@ -0,0 +1,136 @@ | |||
# Bluesky API Connector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update readme.md file with all the required fields mentioned in the below link.
@@ -0,0 +1,73 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update apiProerities.json file as per the below template and schema.
When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
apiDefinition.swagger.json
, by runningpaconn validate
command.apiProperties.json
has a valid brand color and doesn't use an invalid brand color,#007ee5
or#ffffff
. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process: